Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bumpup dbt-bigquery 1.8 #69

Closed
wants to merge 1 commit into from
Closed

Bumpup dbt-bigquery 1.8 #69

wants to merge 1 commit into from

Conversation

w1mvy
Copy link
Contributor

@w1mvy w1mvy commented May 14, 2024

Description

Fixes #68

This PR, included #67.

dbt-core 1.8 has been followed due to its impact on functions used in dbt-dry-run. dbt-labs/dbt-adapters#87

dbt-core 1.8 has just been released, so there may be an idea to wait for the stable version.
I would be happy to point this out to you.

Checklist:

  • I have run make verify and fixed any linting or test errors
  • I have added appropriate unit tests or if applicable an integration test
  • OPTIONAL: I have run make integration against a Big Query instance

@ccharlesgb
Copy link
Collaborator

Hey,

Thanks for the pull request! Looks like all the integration tests are failing (They don't run on the PR GH action) on this branch due to:

.venv/lib/python3.8/site-packages/jinja2/sandbox.py:394: in call
    return __context.call(__obj, *args, **kwargs)
.venv/lib/python3.8/site-packages/dbt/context/secret.py:32: in env_var
    env = get_invocation_context().env
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

    def get_invocation_context() -> InvocationContext:
        invocation_var = reliably_get_invocation_var()
>       ctx = invocation_var.get()
E       LookupError: <ContextVar name='DBT_INVOCATION_CONTEXT_VAR' at 0x1645f02c0>

.venv/lib/python3.8/site-packages/dbt_common/context.py:53: LookupError
________________________________________________________________________________ ERROR at setup of test_tests_for_missing_models_are_not_executed _________________________________________________________________________________

request = <SubRequest 'compiled_project' for <Function test_valid_tests_are_run>>

    @pytest.fixture(scope="module")
    def compiled_project(request: FixtureRequest) -> ProjectContext:
>       return _compiled_project(request, full_refresh=False)

integration/conftest.py:139:

Do you have a way of setting up running the integration tests locally on a project you control? If not I can take a look at figuring out what is going on.

@w1mvy
Copy link
Contributor Author

w1mvy commented May 15, 2024

Thanks your review!! (also about #67

Do you have a way of setting up running the integration tests locally on a project you control?

yes. I was able to reference docs and reproduce it.
But, the investigation is proving difficult.

@ccharlesgb
Copy link
Collaborator

I can take a look this week if its proving difficult. The integration test setup is a bit fiddly.

@ccharlesgb
Copy link
Collaborator

Replacing with #71

@ccharlesgb ccharlesgb closed this May 21, 2024
@w1mvy
Copy link
Contributor Author

w1mvy commented May 22, 2024

I did not take the time to investigate.
Thanks your fix !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support dbt-core / dbt-bigquery 1.8
2 participants
@w1mvy @ccharlesgb