Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of ArcLocks #102

Open
alexandermorozov opened this issue Apr 30, 2016 · 0 comments
Open

Use of ArcLocks #102

alexandermorozov opened this issue Apr 30, 2016 · 0 comments

Comments

@alexandermorozov
Copy link
Contributor

What do you think about removing ArcLocks from Leaf codebase? There is a lot of .read().unwrap(), Arc::new(RwLock::new(..)) and then let inputs_locked: Vec<_> = inputs.iter().map(|b| b.read().unwrap()).collect() that make code harder to read. Users of Leaf also have to wrap inputs in ArcLocks.

I think when autumnai/collenchyma#37 is implemented, there would be less problems with borrowing, and ArcLocks can be removed (but I'm not completely sure yet).

Or are there plans to introduce multithreading that require all inputs/outputs/weights to be wrapped in this way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant