Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style/travis: Allow travis to build on container based system #47

Merged
merged 1 commit into from Feb 21, 2016

Conversation

dirvine
Copy link
Contributor

@dirvine dirvine commented Feb 21, 2016

Added required apt-packages
Added ability to run clippy as feature in nightly
set sudo false in travis

Several remaining compile fixes remain, but will be resolved with upcoming
fix with 0.2 code.

Added required apt-packages
Added ability to run clippy as feature in nightly
set sudo false in travis

Several remaining compile fixes remain, but will be resolved with upcoming
fix with 0.2 code.
@GitCop
Copy link

GitCop commented Feb 21, 2016

There were the following issues with your Pull Request

  • Commit: ef5808f
    • Commits must be in the following format: %{type}/%{scope}: %{description}

Guidelines are available at https://github.com/autumnai/leaf/blob/develop/CONTRIBUTING.md#git-commit-guidelines


This message was auto-generated by https://gitcop.com

@dirvine dirvine changed the title style: Allow travis to build on container based system style/travis: Allow travis to build on container based system Feb 21, 2016
@dirvine
Copy link
Contributor Author

dirvine commented Feb 21, 2016

Is it possible to have some examples of the commit message format? I see you use "style/XXX" where XX is changed file or module. I am not sure if this is what is missing, sorry for any miscommunication here. I Will also dig more into gitcop to see what I can find.

This PR will not pass tests until the 0.2 code commit lands AFAIK.

@hobofan
Copy link
Member

hobofan commented Feb 21, 2016

I see you have figured it out, but you are right, having an example in the guidelines would certainly be nice (issue #48).

Since I saw that #46 passed with the other changes I will go ahead and merge it even though it's failing.

Thanks you! :)

hobofan added a commit that referenced this pull request Feb 21, 2016
style/travis: Allow travis to build on container based system
@hobofan hobofan merged commit 14cc654 into autumnai:master Feb 21, 2016
@hobofan
Copy link
Member

hobofan commented Feb 21, 2016

Oh 😮, only the PR title had the correct format, not the commit. Oh well...

@dirvine
Copy link
Contributor Author

dirvine commented Feb 21, 2016

Ah yes I spotted that just after the merge. Oh well not to worry. Sorry chap, I ended up rebasing (hard) locally and could not get back to the commit. At least I now know. Next time though it will all be good.

@hobofan
Copy link
Member

hobofan commented Feb 21, 2016

Yup, better luck next time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants