Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a messenger support #92

Closed
ujwaldhakal opened this issue Aug 9, 2022 · 2 comments
Closed

Added a messenger support #92

ujwaldhakal opened this issue Aug 9, 2022 · 2 comments

Comments

@ujwaldhakal
Copy link
Contributor

I have added Symfony Messenger support for my use case which was not available by making a separate bundle like this.

Is it okay to create an addon like this from your OpenTracing bundle core?

Here is the link https://github.com/ujwaldhakal/symfony-opentracing-messenger. Let me know what you think

@cawolf
Copy link
Member

cawolf commented Aug 15, 2022

Hi @ujwaldhakal ,
I like the idea very much. It makes sense to have a separate plugin just for the Symfony Messenger component.

I would like to dig a little deeper in the Symfony Messenger component itself, to be able to give you a high quality feedback on the integration.
However, I already glanced over your repository and saw some improvement opportunities - how should I give you feedback? Issues in your repository? Or just using this issue here in OpentracingBundle-core?

@ujwaldhakal
Copy link
Contributor Author

ujwaldhakal commented Aug 15, 2022

I think it would be easier to track the issues in my repository for messenger related stuffs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants