Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font spec request #4

Closed
Ed-Dikotope opened this issue Jul 8, 2020 · 2 comments
Closed

font spec request #4

Ed-Dikotope opened this issue Jul 8, 2020 · 2 comments

Comments

@Ed-Dikotope
Copy link

Dug into the plugin a bit more. It is really awesome. Saved me few hours just when I was about to write my own. Much appreciated.

I wanted to request, as a part of the font spec, that the font "type", local or google, be returned as a part of the change callback on the input. I have a use case where the type is important, but noticed in the spec that only family:weight:style are being returned. Maybe a method to return an object of the selected font somehow that can be consumed? Instead of just setting the input value.

Thanks for looking into this.

@av01d
Copy link
Owner

av01d commented Jul 10, 2020

That's a good idea! I'm already working on it. Expect a new release today.

@av01d
Copy link
Owner

av01d commented Jul 10, 2020

And... it's done. Version 1.0 features an onSelect callback that you can use to find out whether a local or Google font was selected. Use this instead of on('change', ...).

@av01d av01d closed this as completed Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants