Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the linting job #61

Open
richardpringle opened this issue Sep 28, 2023 · 0 comments
Open

Fix the linting job #61

richardpringle opened this issue Sep 28, 2023 · 0 comments

Comments

@richardpringle
Copy link
Collaborator

The linter just fails with clippy and fmt not installed, but then shows up as passing.

It would be much better if the commands were specified directly in the jobs and if they were made simpler.

For instance, we should only be running cargo clippy --all --all-features --examples --tests -- -Dwarnings. If anyone wants to see what's failing, it's easy for them to checkout the .github directory and see the commands all in one place without being lead to separate files.

And, in order to check specific rules, those rules can be specified in lib.rs for each individual crate. For example, just place !#[deny(clippy::pedantic)] at the top of lib.rs instead of calling cargo clippy -- -D clippy::pedantic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant