Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insecure Credential Storage in web3 #257

Closed
imhunterand opened this issue Sep 9, 2022 · 2 comments
Closed

Insecure Credential Storage in web3 #257

imhunterand opened this issue Sep 9, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@imhunterand
Copy link

Describe the bug
All versions of web3 are vulnerable to Insecure Credential Storage. The package stores encrypted wallets in local storage and requires a password to load the wallet. Once the wallet is loaded, the private key is accessible via LocalStorage. Exploiting this vulnerability likely requires a Cross-Site Scripting vulnerability to access the private key.

Recommendation

No fix is currently available. Consider using an alternative module until a fix is made available.
GHSA-27v7-qhfv-rqq8

@imhunterand imhunterand added the bug Something isn't working label Sep 9, 2022
@aaronbuchwald
Copy link
Collaborator

Thanks for reporting this, we are planning to migrate this repo away from all JS dependencies and switch to using Foundry for the smart contract tests.

@ceyonur
Copy link
Collaborator

ceyonur commented Feb 7, 2023

Closing this as we're tracking this migration in #223

@ceyonur ceyonur closed this as completed Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants