Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Docker setup #376

Open
Tracked by #385
cam-schultz opened this issue May 13, 2024 · 2 comments · May be fixed by #393
Open
Tracked by #385

Remove Docker setup #376

cam-schultz opened this issue May 13, 2024 · 2 comments · May be fixed by #393
Assignees
Labels
enhancement New feature or request tooling

Comments

@cam-schultz
Copy link
Contributor

Context and scope
avalanche-cli supports deploying TeleporterMessenger, TeleporterRegistry, and awm-relayer instances for local networks. We should leverage those features for the open-ended development environment included in this repo. It may make sense to remove the Docker environment entirely in favor of running avalanche-cli's local network on native hardware.

Discussion and alternatives
avalanche-starter-kit provides an all-in-one Teleporter development environment with local workflows as well as remote workflows via Github codespaces. We should consider removing the development environment in teleporter altogether in favor of avalanche-starter-kit.

Open questions
How customizable is the awm-relayer deployment via avalanche-cli? We should consider the utility of the avalanche-cli setup for system level development tasks that simultaneously modify awm-relayer and teleporter. For such tasks, the dev container workflow in avalanche-starter-kit may be preferred.

@feuGeneA
Copy link
Contributor

feuGeneA commented May 30, 2024

I took at look at this.

From what I can tell, for avalanche-cli, the Teleporter and AWM Relayer versions that are used must be officially released versions:

  • The Messenger contract deployment functionality simply takes the "Deployment_Transaction" asset from a release (eg v1.0.0) and submits it (see here).
  • And, the obtaining of the AWM Relayer is also by reference to a ...github.../releases/ url, here.

As for avalanche-starter-kit, it seems to be well set up for developing applications on top of Teleporter, but does not seem amenable to development of Teleporter itself. This is because it depends on avalanche-cli to do the Messenger deployment and to start the AWM Relayer.

In short, at this time, I don't think either of these tools can replace the Docker setup this repo uses for developing the Teleporter contracts.

@feuGeneA
Copy link
Contributor

feuGeneA commented Jun 3, 2024

Discussed on a call and decided we should just remove the docker setup entirely since neither CI nor anyone on the team uses that setup.

@feuGeneA feuGeneA linked a pull request Jun 4, 2024 that will close this issue
@feuGeneA feuGeneA changed the title Consider removing Docker setup in favor of avalanche-cli Teleporter integration Remove Docker setup Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tooling
Projects
Status: Backlog 🗄️
Development

Successfully merging a pull request may close this issue.

2 participants