Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 Support #129

Closed
AmitT opened this issue Jan 6, 2021 · 9 comments · May be fixed by #140
Closed

PHP 8 Support #129

AmitT opened this issue Jan 6, 2021 · 9 comments · May be fixed by #140

Comments

@AmitT
Copy link

AmitT commented Jan 6, 2021

Hi,
As far as I see, the SDK has a lot of issues with PHP8:

Deprecated: Required parameter $countryCode follows optional parameter $filter in
/vendor/avalara/avataxclient/src/Methods.php
on line 4214

Deprecated: Required parameter $countryCode follows optional parameter $filter in
/vendor/avalara/avataxclient/src/Methods.php
on line 4240

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 6498

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 6644

Deprecated: Required parameter $model follows optional parameter $include in
vendor/avalara/avataxclient/src/Methods.php
on line 6862

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 8893

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 8948

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9125

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9178

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9234

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9297

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9337

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9574

Deprecated: Required parameter $documentType follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9640

Deprecated: Required parameter $useTaxDateOverride follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9640

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9640

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9693

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9836

Deprecated: Required parameter $model follows optional parameter $include in
/vendor/avalara/avataxclient/src/Methods.php
on line 9890

Deprecated: Required parameter $environment follows optional parameter $machineName in
/vendor/avalara/avataxclient/src/Client.php
on line 57

Can you please update the SDK accordingly?

Thank you,

dissolve pushed a commit to dissolve/AvaTax-REST-V2-PHP-SDK that referenced this issue May 12, 2021
adds travis testing for php versions 7.2, 7.3, 7.4 and 8.0
update invalid function definitions which has required params after
 optional ones (php8.0 refuses to build with these errors)
add guzzle 7 support
closes avadev#119
closes avadev#129
@casingh1990
Copy link

Has there been any movement on getting this forward? Would like to know if the linked PR is good to go or what changes are needed.

@Nacoma
Copy link

Nacoma commented Aug 18, 2021

Is there an ETA for when we will see PHP8 support? This is a major blocker.

@guywarner
Copy link

Based on the response here #138 it doesn't look very good for us.

@guywarner
Copy link

guywarner commented Aug 18, 2021

Can confirm a temporary fix until they get with it.

Fork https://github.com/dissolve/AvaTax-REST-V2-PHP-SDK by @dissolve.

In your composer.json add:

    "repositories": [
      {
        "url": "https://github.com/**YOUR USERNAME**/AvaTax-REST-V2-PHP-SDK",
        "type": "vcs"
      }
    ],

Will fix PHP 8 and Guzzle 7 issues

rlerdorf pushed a commit to rlerdorf/AvaTax-REST-V2-PHP-SDK that referenced this issue Aug 23, 2021
adds travis testing for php versions 7.2, 7.3, 7.4 and 8.0
update invalid function definitions which has required params after
 optional ones (php8.0 refuses to build with these errors)
add guzzle 7 support
closes avadev#119
closes avadev#129
@asegestam
Copy link

I don't get why this has not been fixed yet. Its been an issue for months now - really frustrating

@guywarner
Copy link

I don't either, reason we're moving to Tax Jar

@asegestam
Copy link

I don't either, reason we're moving to Tax Jar

Thanks for the tip @guywarner

@philsturgeon
Copy link

Come on folks, you've got a PR already just click merge.

giphy

@svc-developer
Copy link
Collaborator

This has been completed in 22.3.0 release of SDK. Please confirm.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants