Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat notification sound also plays when a message is sent #103

Open
gergles opened this issue Mar 28, 2018 · 2 comments
Open

Chat notification sound also plays when a message is sent #103

gergles opened this issue Mar 28, 2018 · 2 comments
Assignees
Labels
Milestone

Comments

@gergles
Copy link

gergles commented Mar 28, 2018

There's an iChat style sound played whenever you send a message... then maybe 50 ms later the notification sound set for the chat also plays.

Only the iChat-style sound should play (and we should be able to disable it.)

@avaidyam avaidyam added the bug label Mar 28, 2018
@avaidyam avaidyam added this to the 1.0 milestone Mar 28, 2018
@avaidyam avaidyam self-assigned this Mar 28, 2018
@avaidyam
Copy link
Owner

So you're hearing two notification sounds? Weird - maybe I left some code in on accident in the messages sending process. I've been trying to form an app "event bus" to handle all of these events, so in the future it'll get cleaner, I hope.

@avaidyam
Copy link
Owner

@gergles Fixed the first half of the issue; the next part is user selection of default sounds (and optionally, no sounds) for individual events.

@avaidyam avaidyam reopened this Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants