Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change from System.Logger to use events and control how those events are logged. #47

Closed
rbygrave opened this issue Feb 8, 2023 · 2 comments · Fixed by #51
Closed

Change from System.Logger to use events and control how those events are logged. #47

rbygrave opened this issue Feb 8, 2023 · 2 comments · Fixed by #51
Assignees
Milestone

Comments

@rbygrave
Copy link
Contributor

rbygrave commented Feb 8, 2023

What our config framework provides is a simple event system. When logging is done you can drain the queue of events usually replaying them to logging our System.err.

The reason for doing this is because sometimes we want the configuration to load completely BEFORE any logging is used. This allows the configuration to put things into System Properties which is used to configure the actual logging.

@SentryMan
Copy link
Collaborator

use events

so the first thing that comes to mind is to take the logs we output and keep them in a List somewhere. From there we could provide a method for users to log themselves. Am I on the right track?

@rbygrave
Copy link
Contributor Author

Yes, well an "event" is something like a System.Logger.LEVEL + message (+ maybe a code if we want some business logic to work off codes rather than message content).

@rbygrave rbygrave self-assigned this Feb 15, 2023
@rbygrave rbygrave added this to the 2.5 milestone Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants