index spec files fail

[billyjanitsch]

// test/index.spec.js
import test from 'ava'

test('dummy', t => {
  t.end()
})

Running AVA on this file yields:

  ✔ test › index › dummy
Uncaught Exception:  /Users/billy/projects/ava-test/node_modules/deep-extend/test/index.spec.js
  Error: Cannot find module 'should'
    at Object.<anonymous> (/Users/billy/projects/ava-test/node_modules/deep-extend/test/index.spec.js:5:14)
    at requireFromString (/Users/billy/projects/ava-test/node_modules/require-from-string/index.js:26:4)

Appears to be an issue with require-from-string.

[vadimdemedes]

@floatdrop could you please confirm?

[jamestalmage]

The issue is not with require-from-string.

You have deep-extend installed, which ships with it's own test/index.spec.js, and that is getting picked up with whatever glob string you are using.

Maybe AVA should avoid picking up files in node_modules, even if their glob string says too.

unclechu/node-deep-extend#21

➜  ava-test  ava

  ✔ dummy

  1 test passed

[billyjanitsch]

Ah, my mistake, thanks for clarifying!

[jamestalmage]

@billyjanitsch
Were you using the default glob string, or specifying your own? We should probably prevent AVA from picking that sort of file up by default.

[billyjanitsch]

I was specifying my own, and forgot that it would pick up node_modules.

[jamestalmage]

happens to the best of us.

I opened #226 to discuss the possibility of protecting against this sort of mistake.