Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable past with alpha transparency #469

Closed
wants to merge 1 commit into from
Closed

Enable past with alpha transparency #469

wants to merge 1 commit into from

Conversation

drmovi
Copy link

@drmovi drmovi commented Nov 17, 2015

set alpha transparency for overlay image

set alpha transparency for overlay image
@stof
Copy link
Contributor

stof commented Nov 17, 2015

having a different signature than the interface does not make sense. It defeats the point of being an abstraction library

@drmovi
Copy link
Author

drmovi commented Nov 17, 2015

This is suggestion to add transparency feature to past function

@stof
Copy link
Contributor

stof commented Nov 17, 2015

@drmovi but then, it must be added in the interface and implemented for all libraries.

And I'm not sure changing the existing method is a good idea. It might have unwanted side effects

@drmovi
Copy link
Author

drmovi commented Nov 17, 2015

@stof 3 libraries , i think that is not a big deal

@burzum
Copy link
Contributor

burzum commented Feb 2, 2017

@drmovi any plans to finish this PR? I agree with @stof, it doesn't make sens to merge this without his proposed changes.

@mlocati
Copy link
Collaborator

mlocati commented Aug 28, 2018

Implemented in #639

@mlocati mlocati closed this Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

4 participants