Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Zooming in breaks the UI of the media object page in mobile devices #5410

Closed
1 of 5 tasks
charumitraravi opened this issue Oct 6, 2023 · 6 comments
Closed
1 of 5 tasks
Assignees
Labels

Comments

@charumitraravi
Copy link

charumitraravi commented Oct 6, 2023

Describe the bug
In a mobile browser, The zoom text option is not working as expected. The page text is not getting enlarged, and the player icons move out of visibility.

To Reproduce
1.Open an item in a mobile web browser. The item should contain a media file
2.From the browser settings, choose the zoom option (or "Zoom text" option) and start zooming in.

Expected behavior
The text should be zoomed in, and the player icons and controls should be accessible

Screenshots/Screen Recording

Private Zenhub Video

Environment (please complete the following information):

  • Device / platform - Mobile
  • OS: iOS,Android (need to verify)
  • Browser - Chrome
  • avalon-dev
  • avalon-staging
  • mco-staging
  • mco-production
  • demo

Release:
7.7

Additional notes
This scenario is working fine in the staging environment

@joncameron
Copy link
Contributor

joncameron commented Oct 10, 2023

Most of the elements other than the large play button is on video.js and the way it handles zoom. The CSS for the big play button may need to be adjusted to make sure it isn't part of this issue. No media queries at the moment for the big play button we've added.

Changing to viewport dimensions rather than pixel values could fix this but may possibly affect other elements; we'll need to determine more when testing further.

@elynema elynema changed the title [BUG] Zooming in breaks the UI of the preview page in mobile devices [BUG] Zooming in breaks the UI of the media object page in mobile devices Oct 10, 2023
@Dananji Dananji self-assigned this Dec 11, 2023
@elynema
Copy link
Contributor

elynema commented Dec 12, 2023

Pinch and zoom seems to be behaving ok, text zoom is more of a problem. We assume that on mobile devices, users will be more likely to be using pinch and zoom.

Need to test pinch and zoom on iOS mobile device.

@Dananji
Copy link
Contributor

Dananji commented Dec 14, 2023

I followed the same steps on the main site of VideoJS to zoom in the page, and observed similar behavior there;
bs_realios_Mobile_iPhone 15 Pro-17.0(1).jpg

And also, I tested the existing player with MediaElement.js in MCO, it zooms in the player and shows all the icons as below;

bs_realios_Mobile_iPhone 15 Pro-17.0.jpg

Maybe we could list this as a known issue for the time being until it is fixed in VideoJS?

@joncameron
Copy link
Contributor

+1 to marking it as a known issue since it's coming from Video.js.

@elynema
Copy link
Contributor

elynema commented Jan 23, 2024

Pinch and zoom on a mobile device does not resize anything on a web page. It simply makes the whole page bigger so that you can only see a very small part of it at a time. I don't think there is anything we can change about that, but I think for accessibility purposes for a low vision user, they would be more likely to be zooming via the text size. Not completely sure, though.

Text zoom seemed to work ok in Chrome on Android (Zoom text option) - page text increased in size but player and player controls did not.

In Chrome on iPhone, text zoom increases the size of everything, including the controls in the player. Once zoomed in enough, you begin to lose buttons in the player.

IMG_5567.jpg

The same thing happens in Safari, even at just 115% of text zoom, you lose the full-screen button:

IMG_5569.jpg

@elynema
Copy link
Contributor

elynema commented Jan 23, 2024

@elynema elynema closed this as completed Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants