Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not complete scan #22

Closed
Pharaoh2k opened this issue Sep 3, 2023 · 11 comments
Closed

Can not complete scan #22

Pharaoh2k opened this issue Sep 3, 2023 · 11 comments

Comments

@Pharaoh2k
Copy link

Hi, Avan, just tested the latest 0.9.9.1 beta and noticed the first scan was stuck at the end.
WGwcpyr

When I hit the stop button, I got this error:

System.AggregateException: One or more errors occurred. ---> System.Exception: System.Exception: baseKey must be less than key, baseKey:4904657, key:16
   at PS4CheaterNeo.BitsDictionary.Add(UInt32 key, Byte[] data)
   at PS4CheaterNeo.Query.Comparer(Byte[] buffer, Section section, Int32 scanStep, UInt64 AddrMin, UInt64 AddrMax, BitsDictionary bitsDict)
   at PS4CheaterNeo.Query.<>c__DisplayClass30_3.<ScanTask>b__5()

System.AggregateException: One or more errors occurred. ---> System.Exception: baseKey must be less than key, baseKey:4904657, key:16
   at PS4CheaterNeo.Query.<>c__DisplayClass30_3.<ScanTask>b__5()
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at PS4CheaterNeo.Query.<>c__DisplayClass30_0.<ScanTask>b__0()
---> (Inner Exception #0) System.Exception: baseKey must be less than key, baseKey:4904657, key:16
   at PS4CheaterNeo.Query.<>c__DisplayClass30_3.<ScanTask>b__5()
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()<---



   at PS4CheaterNeo.Query.<>c__DisplayClass30_0.<ScanTask>b__0()
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at PS4CheaterNeo.Query.<ScanTask>d__30.MoveNext()
   --- End of inner exception stack trace ---
---> (Inner Exception #0) System.Exception: System.Exception: baseKey must be less than key, baseKey:4904657, key:16
   at PS4CheaterNeo.BitsDictionary.Add(UInt32 key, Byte[] data)
   at PS4CheaterNeo.Query.Comparer(Byte[] buffer, Section section, Int32 scanStep, UInt64 AddrMin, UInt64 AddrMax, BitsDictionary bitsDict)
   at PS4CheaterNeo.Query.<>c__DisplayClass30_3.<ScanTask>b__5()

System.AggregateException: One or more errors occurred. ---> System.Exception: baseKey must be less than key, baseKey:4904657, key:16
   at PS4CheaterNeo.Query.<>c__DisplayClass30_3.<ScanTask>b__5()
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
   --- End of inner exception stack trace ---
   at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
   at System.Threading.Tasks.Task.Wait(Int32 millisecondsTimeout, CancellationToken cancellationToken)
   at PS4CheaterNeo.Query.<>c__DisplayClass30_0.<ScanTask>b__0()
---> (Inner Exception #0) System.Exception: baseKey must be less than key, baseKey:4904657, key:16
   at PS4CheaterNeo.Query.<>c__DisplayClass30_3.<ScanTask>b__5()
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()<---



   at PS4CheaterNeo.Query.<>c__DisplayClass30_0.<ScanTask>b__0()
   at System.Threading.Tasks.Task`1.InnerInvoke()
   at System.Threading.Tasks.Task.Execute()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at PS4CheaterNeo.Query.<ScanTask>d__30.MoveNext()<---
@avan06
Copy link
Owner

avan06 commented Sep 8, 2023

Hi, Pharaoh2k,
Thank you for bringing up the issue with the ScanTask stop button.
This issue has been fixed in version 0.9.9.2-beta. Thank you.

@Pharaoh2k
Copy link
Author

I still get no results.
To reproduce:

  • Connect to cyberpunk
  • Select the second exec section at address 0500000 (prot 1).
  • Select Byte
  • Select UnknownInitial
  • Scan

These are my exact settings:
hIY7Pmm

@Pharaoh2k
Copy link
Author

by the way. Since the scan obviously finished, but not showing any results in the list, I tried to click the stop button and getting this:
4fnYWHs

@avan06
Copy link
Owner

avan06 commented Sep 9, 2023

I still get no results. To reproduce:

  • Connect to cyberpunk
  • Select the second exec section at address 0500000 (prot 1).
  • Select Byte
  • Select UnknownInitial
  • Scan
    Hi, Pharaoh2k,

After using version 0.9.9.2-beta or a newer version, do you still encounter an error message when the program is stuck on this screen? Does the game that's set to auto-pause automatically resume? It seems that the scan hasn't completed yet (or there might be an issue causing it to get stuck and not complete).

I conducted the same scanning test with Cyberpunk 2077, and the results were normal. However, I haven't played this game, so I performed the scan in the game's initial prologue at the car workshop.

@Pharaoh2k
Copy link
Author

No, avan, I don't get the error message anymore, but the scan never completes when I do the steps I mentioned.
I am attaching my exported config. Maybe you can try to use my config and see if you can reproduce this issue.
PS4CheaterNeoConfig.zip

@Pharaoh2k
Copy link
Author

Sorry, this is the correct json file:
PS4CheaterNeoSettings.zip

@Pharaoh2k
Copy link
Author

Pharaoh2k commented Sep 9, 2023

I think I found the cause. I have set the "Max results show" to 1 million results instead of the default 8,192.
Neo seems to have a hard time listing a long list of results. Even the 8,192 listing isn't instant.
Could you please look into improving the performance of the result listing speed?

@avan06
Copy link
Owner

avan06 commented Sep 9, 2023

I think I found the cause. I have set the "Max results show" to 1 million results instead of the default 8,192. Neo seems to have a hard time listing a long list of results. Even the 8,192 listing isn't instant.

Haha! I didn't expect anyone to set it to a million results here. I can try to improve this part. Thanks, Pharaoh2k, for helping identify the issue!

@avan06
Copy link
Owner

avan06 commented Sep 10, 2023

The efficiency issue in ResultView has been resolved in version 0.9.9.4-beta. Additionally, improvements have been made to the efficiency of SectionView. However, further testing is needed to ensure everything works well due to significant program changes. Thank you.

@Pharaoh2k
Copy link
Author

Indeed the performance is A LOT better than it has ever been! Well done!
I will keep this issue open for now just in case I find any related issues to report here.

@Pharaoh2k
Copy link
Author

Closing this for now. Thanks a lot! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants