Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Hex Editor no open when selected at the PopUp Menu on the Query Window. #30

Closed
JeymyAV opened this issue Sep 9, 2023 · 6 comments

Comments

@JeymyAV
Copy link

JeymyAV commented Sep 9, 2023

I don't know if I am doing something wrong here but based in the below picture:
image

When I click in the Hex Editor PopUp menu then it should be open with the selected section range?

Because what happen to me is that the popup menu close and the Hex Editor is not open...

Is this behavior correct or is it a bug or what I am doing wrong?

Version tested is Neo 0.9.9.3 but I think that it happened on the all previous one too (from 0.9.8.1 until this last one).

@JeymyAV
Copy link
Author

JeymyAV commented Sep 9, 2023

Oh, I just find out what I was did wrong, I have to select the column number section instead of the row with the address...

Well, it is my bad... but should be possible to work the Check PopUp option and the Hex Editor pop up option selecting the row and no only the column with the number section?

If this is too much complicate or hard to implement, let me know and I will close this bug because is not a bug at all..

@avan06
Copy link
Owner

avan06 commented Sep 10, 2023

Because I didn't want checkboxes to be automatically selected when clicking on any column, I restricted the control to the first column position. However, in version 0.9.9.1, a new option "SectionViewFullRowSelect" was added to Query. Enabling it allows you to click on any column, which seems to be what you're looking for.

@JeymyAV
Copy link
Author

JeymyAV commented Sep 10, 2023

Oh, never see this option "SectionViewFullRowSelect" before... Ok enabled and testing...

I see the difference, now it works, I can select the row and the HexEditor is open when I choose the option in the popup menu, but as you said, this has one side-effect, the section is automatically selected.. This behavior is a bit weird...

Humm, Why is automatically checked the section when you click in the row? cannot it be avoid it?

Normally most of Windows application you make the selection of the row when you do double click, no with a single click like is happen now.

On my opinion with this option enable, I would prefer that when the user click on the row, the section only should be mark with the popup menu option "Check" or using double click and not single click of the button mouse like now, but it is up to you decide how it should be work...

Anyway, if you say that this is the design behavior of the tool and you are no going to change it, for me is ok and I will close the issue...

@Pharaoh2k
Copy link

Yeah, I agree with @JeymyAV
If the checkbox can be set to only be checked on double-click, rather than single click which is meant only for highlighting, that's a lot better.

@avan06
Copy link
Owner

avan06 commented Sep 11, 2023

I later noticed the reason for the checkboxes getting selected. It was due to the switch to VirtualMode to improve the SectionView processing speed. VirtualMode has limited support for checkboxes, and some behaviors changed as a result. Now, in version 0.9.9.6-beta, I have improved this. Even with "SectionViewFullRowSelect" enabled, clicking on any column will not cause checkboxes to be selected. Only clicking on the first column will select the checkbox. Thank you.

@JeymyAV
Copy link
Author

JeymyAV commented Sep 11, 2023

Now works as expected. Good work!

@JeymyAV JeymyAV closed this as completed Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants