Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid values for pyenv_env are not obvious #36

Closed
maxalbert opened this issue Apr 12, 2019 · 2 comments · Fixed by #40
Closed

Valid values for pyenv_env are not obvious #36

maxalbert opened this issue Apr 12, 2019 · 2 comments · Fixed by #40

Comments

@maxalbert
Copy link
Contributor

Many thanks for providing this ansible-galaxy role @avanov! :)

Just a minor issue for usability: from the README it is not immediately clear what the valid values for the pyenv_env are. Looking at tasks/main.yml it, the suggested values seem to be "user" and "system".

As far as I can tell at a glance, it doesn't actually matter what the value is if it's different from "user", but from a user-friendliness perspective it would be nice if the "system" value was documented explicitly because it makes the meaning of the variable clearer.

@avanov
Copy link
Owner

avanov commented May 17, 2019

Hi @maxalbert , thank you for your feedback. I agree with you, the documentation is somewhat outdated and I'd like to find some time to clear it up at some point or to accept any changes regarding that as a PR. It's just I barely have spare time for it at the moment and it may take a while.

@maxalbert
Copy link
Contributor Author

No problem @avanov, I totally understand the issue of finding spare time for one's projects.

I opened PR #40 for a quick fix of this particular issue. Feel free to move this information into a different section of the README or document it differently whenever you find time for a more substantial brush-up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants