Allow fixture to return multiple compose files #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As described in https://docs.docker.com/compose/extends/, docker compose can be passed multiple compose files that are then merged. This change allows the `docker_compose_file` fixture to make use of this by returning e.g. a list or a tuple.
The previous solution was breaking backward compatibility when for instance `docken_compose_file` was returning a `py.path` path (used by pytest internally, e.g. for `pytestconfig.rootdir`). This makes it more conservative and more backward compatible.
1 similar comment
|
Nice! Thanks for contributing this! |
|
Just released this on PyPI: https://pypi.org/project/pytest-docker/0.6.0/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in https://docs.docker.com/compose/extends/, docker compose
can be passed multiple compose files that are then merged. This change
allows the
docker_compose_filefixture to make use of this byreturning e.g. a list or a tuple.