Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar title: Expression changed after change detection #8

Closed
avatsaev opened this issue Aug 4, 2017 · 1 comment
Closed

Toolbar title: Expression changed after change detection #8

avatsaev opened this issue Aug 4, 2017 · 1 comment
Assignees
Labels

Comments

@avatsaev
Copy link
Owner

avatsaev commented Aug 4, 2017

Description

Currently lazy loaded container views change the page title of the toolbar. Considering views are at the bottom of the component tree, and change data of top level component (toolbar title), it violates angular's one way data flow principle (Data must flow from top to bottom).

Proposal

  • Dispatch set title action at main app component level, and store route titles in router data.

OR

  • Use route resolvers to dispatch the set title action
@avatsaev avatsaev added the bug label Aug 4, 2017
@avatsaev avatsaev self-assigned this Aug 4, 2017
@avatsaev
Copy link
Owner Author

avatsaev commented Aug 4, 2017

Used resolvers to fix the issue.

@avatsaev avatsaev closed this as completed Aug 4, 2017
@avatsaev avatsaev reopened this Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant