Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sealed Classes #7

Closed
dballance opened this issue Jun 8, 2023 · 3 comments
Closed

Sealed Classes #7

dballance opened this issue Jun 8, 2023 · 3 comments

Comments

@dballance
Copy link

https://dart.dev/language/class-modifiers#sealed

Admittedly I haven't dug too deep here - but seems like a sealed annotation would be a nice addition for this lib.

Might need to be a separate package to maintain compatibility with Dart < 3.0.

Happy to take a stab at it at some point in the next week or two if you'd like!

@avdosev
Copy link
Owner

avdosev commented Jun 9, 2023

I agree, this is a useful application of the new language feature for this library.

Might need to be a separate package to maintain compatibility with Dart < 3.0.

Probably some users are not using the newest version of dart, but in my opinion creating a separate package makes no sense, considering that switching to a new version is not difficult, and the current main part of the library has enough api for most cases.

@avdosev
Copy link
Owner

avdosev commented Jun 10, 2023

ready in 1.0.0 release

@avdosev avdosev closed this as completed Jun 10, 2023
@dballance
Copy link
Author

Excellent!

I agree that it should stay in this package - was just unsure the appetite for the breaking change. Seems like 1.x rev is a good way to handle it - given that people should be moving to Dart 3.0 soon and the existing release API is plenty stable.

🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants