Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoReportCard is struggling with go 1.18 and golint #4114

Closed
spekary opened this issue Mar 21, 2022 · 3 comments
Closed

GoReportCard is struggling with go 1.18 and golint #4114

spekary opened this issue Mar 21, 2022 · 3 comments

Comments

@spekary
Copy link
Collaborator

spekary commented Mar 21, 2022

GoReportCard's github is reporting the following:

Go 1.18 generics is not working in gofmt or golint

golint has been deprecated and is not likely to be fixed.

@spekary
Copy link
Collaborator Author

spekary commented Mar 23, 2022

GoReportCard has removed golint from its list of tools. I have recommended to them that they use staticcheck instead.

So, at this point in time, we will not be able to evaluate code quality with a linter unless we run it ourselves.

@spekary
Copy link
Collaborator Author

spekary commented Mar 31, 2022

@avelino how shall we handle this? GoReportCard currently has no linter. I have recommended that they move to golangci-lint.run. Should we start asking for an output of that, or set up our own golangci-lint.run, or just accept whatever goreportcard is producing for now?

@avelino
Copy link
Owner

avelino commented Apr 1, 2022

Sorry for the delay in answering

As GoReportCard does not yet support Go 1.8 (generic), we will disregard this iteM from the checklist and validate the others

GoReportCard is an open source project and this issue was opened there, we can contribute to it gojp/goreportcard#381

As a second step we need to have our tools to depend as little as possible on third-party services

@avelino avelino closed this as completed May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@avelino @spekary and others