Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First comment action is not working #4939

Closed
1 task done
earthboundkid opened this issue Jul 21, 2023 · 9 comments · Fixed by #5033
Closed
1 task done

First comment action is not working #4939

earthboundkid opened this issue Jul 21, 2023 · 9 comments · Fixed by #5033

Comments

@earthboundkid
Copy link
Contributor

Search first

  • I searched and no similar issues were found

What Happened?

I opened a PR and the first comment action failed. See https://github.com/avelino/awesome-go/actions/runs/5617543194.

Seems like a regression of #4868.

@avelino
Copy link
Owner

avelino commented Jul 21, 2023

@carlmjohnson Can you send a corrected contribution?

@earthboundkid
Copy link
Contributor Author

You mean open a new PR?

@earthboundkid earthboundkid mentioned this issue Jul 21, 2023
10 tasks
@earthboundkid
Copy link
Contributor Author

@khanhtc1202
Copy link
Contributor

khanhtc1202 commented Jul 22, 2023

The error looks like it is a problem with the permission, got the same error all the time

RequestError [HttpError]: Resource not accessible by integration
at /home/runner/work/_actions/peter-evans/create-or-update-comment/v3/dist/index.js:4694:21
at processTicksAndRejections (node:internal/process/task_queues:96:5) {
status: 403,

Maybe it is caused by the GITHUB_TOKEN does not have enough permission to perform its action, could you recheck?
https://github.com/avelino/awesome-go/blob/main/.github/workflows/pull-request-first-comment.yaml#L14

ref: https://github.com/peter-evans/create-or-update-comment#action-inputs

@richardwilkes
Copy link
Contributor

richardwilkes commented Aug 3, 2023

This problem has been around for several months now, despite this issue only being posted recently. Is anyone actually looking into it?

@regnull
Copy link

regnull commented Aug 4, 2023

I added a possible fix to #4961, not sure how to test it without creating a new dummy PR, and I don't want to spam the repo.

@regnull
Copy link

regnull commented Aug 4, 2023

I added a possible fix to #4961, not sure how to test it without creating a new dummy PR, and I don't want to spam the repo.

Since the issue appears to be fixed, I've removed the fix from #4961.

@richardwilkes
Copy link
Contributor

I don't see a way to get the PR to re-run the action that was failing due to an expired token. Does this mean we need to kill our PRs and re-submit them?

@Prastiwar
Copy link
Contributor

@avelino I've provided a fix with all the explanation on this PR:

In order to completely verify the fix without and have 100% confidence instead relying on GitHub information the PR should be either:

  • recreated by you
  • merged and new test one should be created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants