Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing array attributes #369

Merged
merged 12 commits into from Nov 17, 2021
Merged

Missing array attributes #369

merged 12 commits into from Nov 17, 2021

Conversation

johakoch
Copy link
Collaborator

@johakoch johakoch commented Nov 5, 2021

  • create at least an empty array for SAML attributes listed in array_attributes
  • changed HCL conversion of empty arrays
Reviewer checklist
  • Read PR description: a summary about the changes is required
  • Changelog updated
  • Documentation: docs/{Reference, Cli, ...}, Docker and cli help/usage
  • Pulled branch, manually tested
  • Verified requirements are met
  • Reviewed the code
  • Reviewed the related tests

@johakoch johakoch linked an issue Nov 5, 2021 that may be closed by this pull request
SAML array_attributes should always be arrays #357
Closed
@johakoch
Copy link
Collaborator Author

johakoch commented Nov 8, 2021

@malud any objections to 521e097?

@johakoch johakoch marked this pull request as ready for review November 8, 2021 17:40
alex-schneider
alex-schneider previously approved these changes Nov 15, 2021
View reviewed changes
malud
malud requested changes Nov 16, 2021
View reviewed changes
accesscontrol/saml2.go Show resolved Hide resolved
internal/seetie/convert.go Outdated Show resolved Hide resolved
internal/seetie/convert.go Outdated Show resolved Hide resolved
@malud malud merged commit 940c6a0 into master Nov 17, 2021
@malud malud deleted the missing-arrayAttributes branch November 17, 2021 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malud malud malud approved these changes

@alex-schneider alex-schneider alex-schneider left review comments

Assignees

@malud malud

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SAML array_attributes should always be arrays
3 participants
@johakoch @malud @alex-schneider