-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{{data-attribute}} Not Matching #2
Comments
As another example, this in the README:
Would return all the text in the body. |
This line:
Could be changed to something like this:
|
However, there may be greater repercussions in that handler function. |
Curses. Will look at this today. |
I tested my suggested change, it works for me. Do you want a pull request? |
Feel free to keep using your fixed version, but you were right, this goes a little deeper. Will push a broader fix this evening. |
Okay, should be fixed. There's another bug, at the moment, where you can't do the following:
...because, of course, you're overwriting the previous .config. Will start my own issue on this, but it will require some other, less pleasant changes. |
Scratch my previous comment, that can be resolved by just calling Trackiffer a second time with the other '.config'. |
It would be cool if it could all be in one block, but if that is a nasty fix, no worries. |
Well, it would be a big syntax change if we wanted to continue using standard JS methods - it might look like...
...or maybe...
...or even...
Not thrilled with an of these. An alternative would be a little workaround, which is cute but introduces a new idea (Trackiffer-specific syntax) into a known concept (jQuery selectors):
|
Because of the change from the previous issue fixing delegation, the $elem in getReplacement() is not what I would expect.
Doing this doesn't work:
Doing this does:
$elem appears to be assigned to the matched element for 'body.controller.index', rather than the delegated match.
The text was updated successfully, but these errors were encountered: