Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out why line numbers aren't reported when there is a parsing error #81

Closed
avh4 opened this issue Dec 12, 2015 · 1 comment
Closed

Comments

@avh4
Copy link
Owner

avh4 commented Dec 12, 2015

The code relating to error reporting originally came from elm-compiler, and I haven't looked through most of it yet. Currently if there is a syntax error when parsing, no line numbers are reported. (Also, the filename is not currently reported, but that is a separate issue (see #44).)

Are the positions of parse errors not being recorded by the parser, or are they recorded and not being shown? Does elm-compiler/elm-make even show line numbers for syntax (parse) errors, or only for type errors? What do we need to do to get elm-format to show line numbers when there is a parse error?

@avh4 avh4 added this to the 1.0.0 public stable release milestone Dec 12, 2015
@avh4 avh4 changed the title Understand why line numbers aren't reported when there is a parsing error Figure out why line numbers aren't reported when there is a parsing error Dec 14, 2015
@avh4 avh4 removed the help wanted label Feb 8, 2016
@avh4
Copy link
Owner Author

avh4 commented Feb 8, 2016

Seems to be fixed by #128.

@avh4 avh4 closed this as completed Feb 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant