Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Add support for Premium Enhanced Bitrate #99

Closed
fizzfaldt opened this issue Jun 3, 2023 · 14 comments · Fixed by #102
Closed

[Feature request] Add support for Premium Enhanced Bitrate #99

fizzfaldt opened this issue Jun 3, 2023 · 14 comments · Fixed by #102
Labels
enhancement New feature or request

Comments

@fizzfaldt
Copy link

Is your feature request related to a problem? Please describe

I have Youtube Premium.
Youtube added a "1080P Premium Enhanced Bitrate" option, but the "Youtube AutoHD" extension will never choose it.
I don't know if there are other premium bitrates for higher resolutions...

It would be nice to have premium enhanced bitrate automatically chosen when it is the best option.
I know that most people do not have youtube premium, so you'd either need to autodetect premium or give us an toggle on the extension to choose whether to allow it or not. (e.g. don't cause a regression that brings back #80 )

Is it a change to the extension's functionality or to the pop-up settings page?

Extension's functionality

If the latter, please propose a new design on Figma or describe it as detailed as possible

No response

Additional context

No response

@fizzfaldt fizzfaldt added the enhancement New feature or request label Jun 3, 2023
@avi12
Copy link
Owner

avi12 commented Jun 3, 2023

That's a great feature! I'm also a YouTube Premium customer but sadly I've never encountered the "1080P premium enhanced bitrate" option
Please link me to at least one video that has the enhanced bitrate quality option so I can adjust the code accordingly

@fizzfaldt
Copy link
Author

@avi12
Copy link
Owner

avi12 commented Jun 3, 2023

Sadly I don't see the option 😕
image

Tested on both Edge and Chrome, YouTube doesn't show the enhanced quality option in either

What country are you from?

@fizzfaldt
Copy link
Author

I'm in USA.

I see the option in Chrome & Firefox on linux, Firefox&Chrome&Safari on Mac (but only if logged in to my premium account).

When not signed in I don't see the option at all.
When signed in to a non-premium account I don't see the option at all.

@fizzfaldt
Copy link
Author

fizzfaldt commented Jun 3, 2023

I don't see the option on android.

I don't have easy access to windows but I can test it if necessary to check Edge/...
County Country might be the issue?

@avi12
Copy link
Owner

avi12 commented Jun 3, 2023

County might be the issue?

I'm looking into it

@avi12
Copy link
Owner

avi12 commented Jun 3, 2023

What is your GPU?

@fizzfaldt
Copy link
Author

fizzfaldt commented Jun 3, 2023

On linux box 1
AMD Radeon™ RX 6900 XT

On macbook pro dual gpus:

  1. Intel UHD Graphics 630 1536MB
  2. Radeon Pro 555X [EDIT forgot to check for dual gpus here]

On Linux Box 2
NVIDIA Corporation GP107GL [Quadro P620] (rev a1)

Linux box 3:
NVIDIA Corporation GP106 [GeForce GTX 1060 6GB] (rev a1

All four machines get the premium option

@avi12
Copy link
Owner

avi12 commented Jun 3, 2023

After chatting with a YouTube support agent, I understand that only a selected group of users have this feature, or in his own words,

The feature is not yet released for all users and is still slowly rolling out.

@fizzfaldt
Copy link
Author

Updated the macbook pro gpus (dual, not sure how /when it switches)

@avi12
Copy link
Owner

avi12 commented Jun 3, 2023

Linux box 3:
NVIDIA Corporation GP106 [GeForce GTX 1060 6GB] (rev a1

Interesting. My primary computer has GTX 1080 TI, which suggests that it's not a hardware issue

I was thinking it was a hardware issue due to this feature

@fizzfaldt
Copy link
Author

The feature is not yet released for all users and is still slowly rolling out.
That's disappointing but I guess not surprising?

I understand if you want to wait for it to roll out further to make it much easier to figure out.
If you want me to run any console commands/copy/paste some source let me know.

@avi12
Copy link
Owner

avi12 commented Jun 3, 2023

Thanks for your cooperation!
In the following week, it will be challenging, in terms of my schedule, to find free time to deal with this feature
But I'll definitely need your help, like sideloading a version of YTHD
Please get in touch via Discord: avi12#4269

@avi12
Copy link
Owner

avi12 commented Jun 16, 2023

Hey, I pinged you on Discord

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants