Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why there is no inheritance ? #79

Closed
chaouiy opened this issue Dec 13, 2017 · 1 comment
Closed

Why there is no inheritance ? #79

chaouiy opened this issue Dec 13, 2017 · 1 comment

Comments

@chaouiy
Copy link

chaouiy commented Dec 13, 2017

I can't find any inheritance between components, services, etc. I think the project is missing this good practice to define common logic in parent class.
@pkrawat1
Copy link
Member

We appreciate your feedback! Please feel free to define a scenario in our context where possibly we could have used inheritance or point our a file/structure which is not right! Thanks

@pkrawat1 pkrawat1 closed this as completed Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pkrawat1 @chaouiy