Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change casing style for gateway config options to use elixir styling not gateway style. #39

Closed
pkrawat1 opened this issue Dec 22, 2017 · 2 comments

Comments

@pkrawat1
Copy link
Member

pkrawat1 commented Dec 22, 2017

Currently, we are using the gateway expected case styling in the gateway config block in the application code.

This introduces a lot of disparity in between the gateway configs.

Proposal:-

We have a common style and we create a map at gateway level in library to interface gateway keys with config application level keys.

Changes to be made in all the existing gateways;

  • Map all the application level config keys to the gateway specific keys and then send the request.
  • any other changes?.. developing...

This would ensure that we have a consistent API for config.

@oyeb
Copy link
Contributor

oyeb commented Dec 24, 2017

I'm sorry I don't understand the issue. Could you link to the offending code to make this clear?
What is "case styling"? snake_case vs CamelCase?
The Elixir Naming Conventions do allow CamelCase atoms, though not in (core) Elixir.

@oyeb oyeb added this to Need discussion in Gringotts [low-hanging-fruit] Jan 15, 2018
@pkrawat1 pkrawat1 removed this from the Release 1.5.0 milestone Jan 25, 2018
@oyeb
Copy link
Contributor

oyeb commented Jun 4, 2018

Done 🎉

@oyeb oyeb closed this as completed Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Gringotts [low-hanging-fruit]
  
Need discussion
Development

No branches or pull requests

2 participants