Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mix task] Needs test templates, tests #80

Closed
oyeb opened this issue Jan 15, 2018 · 1 comment
Closed

[mix task] Needs test templates, tests #80

oyeb opened this issue Jan 15, 2018 · 1 comment
Assignees
@oyeb
Labels
discussion enhancement severity: medium
Projects
Gringotts [low-hanging-fruit] Gringotts [next-release]

Comments

@oyeb
Copy link
Contributor

oyeb commented Jan 15, 2018

gringotts.new

Generates just a gateway implementation file, it should also create:

  • test/gateways/<gateway>_test.exs
  • test/integration/gateways/<gateway>_test.exs

Which mocking library do we endorse, bypass or mox (I'm strongly against mock)?

Test coverage

The task has no coverage, take inspiration from phx.new.
@oyeb oyeb self-assigned this Jan 15, 2018
@oyeb oyeb added this to In progress in Gringotts [low-hanging-fruit] Jan 15, 2018
@pkrawat1
Copy link
Member

I think mox is a good option here.

@oyeb oyeb added this to To Do in Gringotts [next-release] Jan 24, 2018
@oyeb oyeb mentioned this issue Apr 22, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oyeb oyeb

Labels
discussion enhancement severity: medium
Projects
No open projects
Gringotts [low-hanging-fruit]
  
In progress
Gringotts [next-release]
  
To Do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pkrawat1 @oyeb