Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Resursively close files from command palette [Don't fixed] #1

Closed
Kristinita opened this issue Feb 24, 2017 · 8 comments

Comments

@Kristinita
Copy link

1. Request

It would be nice, if will be possible to close files recursively from command palette.

2. Justification

I think, that working in command palette — is better. This saves time in comparison with navigation in the sidebar. About more reasons see here.

3. Desirable behavior

For example, I have folder RootFolder:

D:\RootFolder
├───FirstSubfolder
│       FirstFile.txt
│
├───SecondSubfolder
│       SecondFile.txt
│
└───ThirdSubfolder
    └───Subsubfolder
            ThirdFile.txt

FirstFile.txt, SecondFile.txt and ThirdFile.txt open for me in Sublime Text. I open tab with FirstFile.txtCtrl+Shift+PCloseFolder: Close Folder Recursively → all files in RootFolder, include SecondFile.txt and ThirdFile.txt close for me.

Thanks.

@aviaryan
Copy link
Owner

Good idea. Will work on it.

@aviaryan
Copy link
Owner

FirstFile.txt, SecondFile.txt and ThirdFile.txt open for me in Sublime Text. I open tab with FirstFile.txt → Ctrl+Shift+P → CloseFolder: Close Folder Recursively → all files in RootFolder, include SecondFile.txt and ThirdFile.txt close for me.

Hey just noticed that there is something wrong here. CloseFolder can't go back in hierarchy. So when you give CloseFolder command from FirstFile.txt, all files in same directory as FirstFile.txt and everything below it will be closed. (eg > RootFolder/FirstFolder/AnotherFolder/someFile.txt) .. Everything inside RootFolder won't be closed.

@aviaryan
Copy link
Owner

aviaryan commented Feb 24, 2017

Added the Command Palette option in new release v1.1.0
https://github.com/aviaryan/CloseFolder/releases/tag/v1.1.0

@Kristinita
Copy link
Author

@aviaryan ,

CloseFolder can't go back in hierarchy.

My feature request about go back in hierarchy( .

Thanks.

@aviaryan
Copy link
Owner

@Kristinita Well that's not possible because there is no way to define a fixed point of how back we should go in the hierarchy. Suppose, if we go unlimited levels back, we would end up closing all open tabs. (when you have just one folder in project) This is obviously something you don't want.

@Kristinita
Copy link
Author

Kristinita commented Feb 24, 2017

@aviaryan , I save my projects, for example, in paths D:\Project1, D:\Project2 and so on. Is possible to configure the fixed points.

Thanks.

@aviaryan
Copy link
Owner

I guess I should close this issue now as this feature can't be implemented under the scope of the project. Though the command palette addition of the command is really cool. So thanks for the report @Kristinita .

@Kristinita
Copy link
Author

@aviaryan , the problem not solved. I think, that will be better reopen issue — perhaps, other developers add this feature.

Thanks.

@Kristinita Kristinita changed the title [Feature request] Resursively close files from command palette [Feature request] Resursively close files from command palette [Don't fixed] Mar 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants