Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The av command tool is somehow triggering duplicate GitHub Action Workflows #332

Open
jasonroelofs opened this issue Jun 13, 2024 · 4 comments

Comments

@jasonroelofs
Copy link

I will amend this issue later with something reproducible but wanted to get this written down to see if it's a known issue or known fix. We are running our CI through GitHub Actions and for a while we've had times where people using av end up in a situation where everything is passing, but Aviator fails the merge because it's referencing a workflow run full of cancelled workflows.

These workflows are cancelled due to our concurrency setting, and it turns out that pushing with av (for example av sync --trunk) is triggering the same workflow multiple times. This then gets problematic with Aviator Merge Queue as it picks up only one of these runs and it's a random bet if it will get the cancelled one or the full run.

We've found that doing a normal git push on the same branch kicks Aviator and the Merge Queue process back to a usable state as only one of each workflow is triggered as expected.

Has anyone seen this before? Is this a known issue? Again I'll do some more local testing to see if I can pin down what may be happening and will report back.

An example duplicate and cancel situation we're running into:

CleanShot 2024-06-13 at 18 25 12@2x

Thanks

@jainankit
Copy link
Contributor

jainankit commented Jun 14, 2024

Sharing here for posterity:
Discussed over email, this might be fixed with the latest upgrade of stack sync. With the latest version, the stack sync only publishes to remote once.

Leaving the ticket open to wait for verification.

@Brookke
Copy link
Contributor

Brookke commented Jul 3, 2024

@jainankit Seeing the same thing with av stack submit (version v0.0.39)
image

@jainankit
Copy link
Contributor

Hi @Brookke, I discussed this briefly over an email chain with @jasonroelofs . We have verified this behavior internally. It seems like even when we do a single git push to multiple branches, GitHub is triggering the webhook and CI multiple times.

Unfortunately, I'm not sure if there's a good solution to avoid this retriggering.

@Brookke
Copy link
Contributor

Brookke commented Jul 9, 2024

I need to dig into the code some more, but does AV not just call git push under the hood?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants