Simplify code where possible #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constructing a new maxtrix via a closure saves us one zeriozation and two temporary heap allocations.
Prefer: 1. sqrt over pow(0.5) 2. powi over powf when exponent is a whole number (1) is detected by clippy. (2) is not, but it is called out in Rust's documentation. Additionally, enable clippy::suboptimal-flops in CI.
JayKickliter
force-pushed
the
jsk/cleanup
branch
from
4a8dd2a
to
eb1f425
Compare
This helps to avoid intermediate allocations by skipping the step of creating an intermediate Vec. This only affects test code, so it's not a big deal, but sets the precedent for future contributers who may be unfamiliar with ndarray's features.
|
Looking forward to it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a non-comprehensive1 effort to:
1: I have another branch with more aggressive, but API breaking, optimizations that remove a lot of heap allocations. I can open a follow-up PR for that along with a major version bump.