Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iPhone X support #48

Closed
HiveHicks opened this issue Oct 20, 2017 · 12 comments
Closed

Add iPhone X support #48

HiveHicks opened this issue Oct 20, 2017 · 12 comments

Comments

@HiveHicks
Copy link
Member

No description provided.

@HiveHicks HiveHicks added this to the 2.1.0 milestone Oct 20, 2017
@HiveHicks HiveHicks self-assigned this Oct 20, 2017
@jackpaster
Copy link

@HiveHicks hello, I opened the same issue and you told me you would have the project fully functional with iPhone X. There’s still a lot of issues that need to be issues with the design. When are you positive you will have it all done. I just need to know when so I can release my app.

@HiveHicks
Copy link
Member Author

@jackpaster sorry to keep your waiting, it was a busy week for me. There are still a few issues with iPhone X, but most of the work is done. Use develop branch to stay up-to-date until we release 2.1.0.

@jackpaster
Copy link

The size of each image in the picker when your scrolling through the images you can edit in the slider are massive. And there’s a bug when you click the photo library button for the first time the cancel and done buttons don’t layout. Do you think you can have the look and these small things that make a big difference done this week. I’m really overdue for release that’s why I’m asking.

@jackpaster
Copy link

@HiveHicks when will 2.1.0 be released. Is there a timeline

@HiveHicks
Copy link
Member Author

The size of each image in the picker when your scrolling through the images you can edit in the slider are massive. And there’s a bug when you click the photo library button for the first time the cancel and done buttons don’t layout

As I already said, you need to use develop branch. These bugs have already been fixed there.

In your Podfile:

pod 'Paparazzo', :git => 'https://github.com/avito-tech/Paparazzo', :branch => 'develop'

@HiveHicks
Copy link
Member Author

That's how Paparazzo looks like on iPhone X in develop

2017-11-21 16 03 40

2017-11-21 16 03 58

@jackpaster
Copy link

@HiveHicks you said there are still a few issues that need to be fixed. If it looks good like you said. What are the few issues that need to be fixed for the iPhone X. And when do you expect to complete them all. Thanks

@HiveHicks
Copy link
Member Author

@jackpaster everything should be fixed now in develop branch. If you find any issues, feel free to post it here.

@jackpaster
Copy link

@HiveHicks Two questions. Can you merge the new design for the photo library with the develop branch and make it one whole branch, and can you make the new photo library design iPhone x compatible. What is the timeline for these two requests do you think

@jackpaster
Copy link

jackpaster commented Nov 27, 2017

@HiveHicks What do you think will you eventually merge the two branches and will the photo library be updated to iPhone x

@HiveHicks
Copy link
Member Author

This feature is being tested at the moment. We will merge it into develop as soon as it's approved by our QA specialists. Hopefully this week, but I can't tell you the exact date.

@jackpaster
Copy link

@HiveHicks thanks its a great update. I love the updated design so much so I hope you guys get it in really soon

@HiveHicks HiveHicks modified the milestones: 2.1.0, 3.0.0 Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants