Skip to content

Consider improving ListElement methods signatures? #7

Closed
dmitriigriazin opened this issue May 4, 2018 · 1 comment
Closed

Consider improving ListElement methods signatures? #7

dmitriigriazin opened this issue May 4, 2018 · 1 comment
Labels
enhancement New feature or request
Milestone
1.0

Comments

@dmitriigriazin
Copy link
Contributor

val view: PageObjectElement = typedItemByMatcher(withId(R.id.payment_loading_view)) will actually find item by position:

Check descendant view with id: com.avito.android.dev:id/payment_loading_view on 0-th item matching: holder with view

because it calls the overload typedItemByMatcher( matcher: Matcher<View>, position: Int = 0 )

Might be confusing.
@lukaville lukaville mentioned this issue Jun 4, 2018
Closed
@dsvoronin dsvoronin added the enhancement New feature or request label Jun 21, 2018
@nesterov-n
Copy link
Contributor

Seems like this function searches for the first occurrence of a child that matches the passed matcher. What can confuse here?

@dsvoronin dsvoronin added this to the 1.0 milestone Aug 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
3 participants
@dsvoronin @nesterov-n @dmitriigriazin