Dynamic batch #14
Merged
Dynamic batch #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemcpp
force-pushed
the
dynamic-batch
branch
from
9558968
to
15990ae
Compare
bugrimov
requested changes
Nov 22, 2021
ivansanin
reviewed
Nov 23, 2021
aqueduct/worker.py
Outdated
| """Provides suitable for processing tasks.""" | ||
| while True: | ||
| try: | ||
| def _get_task(self, timeout: float): |
There was a problem hiding this comment.
Suggested change
| def _get_task(self, timeout: float): | |
| def _get_task(self, timeout: float) -> Optional[BaseTask]: |
ivansanin
reviewed
Nov 23, 2021
aqueduct/worker.py
Outdated
| if self._stop_task or timeout <= 0: | ||
| return batch | ||
|
|
||
| timeout = max(timeout, 0.1) |
There was a problem hiding this comment.
Suggested change
| timeout = max(timeout, 0.1) | |
| timeout = max(timeout, 0.001) |
ivansanin
reviewed
Nov 23, 2021
aqueduct/worker.py
Outdated
|
|
||
| # wait first task | ||
| while True: | ||
| task = self._get_task(10.) |
There was a problem hiding this comment.
Please add a comment why do we use exactly 10 seconds
artemcpp
force-pushed
the
dynamic-batch
branch
from
15990ae
to
3b4fee6
Compare
bugrimov
approved these changes
Nov 23, 2021
aqueduct/flow.py
Outdated
| @@ -243,18 +244,34 @@ def step_names(handlers): | |||
| return {queue_: f'from_{from_}_to_{to}' | |||
| for queue_, (from_, to) in zip(self._queues, step_names(self._contexts))} | |||
|
|
|||
| async def _fetch_processed(self): | |||
There was a problem hiding this comment.
In line 52 you need to change default timeout to None: batch_timeout: Optional[int] = None
| try: | ||
| def _get_task(self, timeout: float): | ||
| try: | ||
| if timeout == 0: |
There was a problem hiding this comment.
Because 0 change behavior of batching, it is better to use None-value. To show users that behavior is different than integer value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When batch_timeout is set to 0 use alternative batching stratagy.
Instead of waiting fixed timeout while batch is ready, grab all task6 that are curentely in input queue and process them right away. We effectively using queue as batch buffer.