Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Cover Image #186

Closed
lexstefan opened this issue Feb 12, 2024 · 6 comments · Fixed by #188
Closed

Bug: Cover Image #186

lexstefan opened this issue Feb 12, 2024 · 6 comments · Fixed by #188

Comments

@lexstefan
Copy link

lexstefan commented Feb 12, 2024

Provide environment information

Package Versions:

"next": "14.1.0",
"outstatic": "^1.3.0",

What browser are you using? (if relevant)

Firefox

How are you deploying your application? (if relevant)

localhost:3000

Describe the Bug

Proceeded to follow "Add To Next.js" instructions from documentation. Everything ran perfectly until i added coverImage for products collections. Inconsistent behavior with coverImage

Expected Behavior

Whenever i edit a collection item [product / post] i expect the previously uploaded coverImage to show up. Feedback if there is an error uploading the image.

Link to reproduction - Issues with a link to complete (but minimal) reproduction code will be addressed faster

https://not-required.com

To Reproduce

  1. add a product or post, add title, add description, add coverImage
  2. set to published & save
  3. git pull --rebae [to get content from github on localhost]
  4. navigate around inside outstatic, here and there
  5. go back to same product to add additional details in the editor [at this point the previously uploaded image is no longer present / shows up in editor]
  6. save the document
  7. git pull --rebase again, and we can clearly see that the coverImage from the markdown file was deleted cleared
  8. at this point i tried uploading the exact same image and i got no feedback, but the image was not uploading [maybe github threw an error because it's the same image]
@lexstefan
Copy link
Author

lexstefan commented Feb 12, 2024

P.s.: I switched the coverPhoto to link, then back to upload just so i can use that field again. I think it got cleared or something.

@avitorio
Copy link
Owner

I got that error when uploading a file recently but couldn't replicate it.

What filetype were you trying to upload? Jpeg?

@lexstefan
Copy link
Author

lexstefan commented Feb 12, 2024

Hello, was png and webp / just checked / didn't realize formats up until now.

@philals
Copy link

philals commented Feb 19, 2024

Hi @avitorio . Great project! The only git based CMS I managed to get working with no issues first time.

I have something simular. Fresh install on Vercel.

I click to edit a post and ONLY add an "!" on the title. This results in this diff: philals/outstatic-blog@e3e1895#diff-91152342c460b4e6bd7368b5061c6cf71990798542f61996812fcb91bf91d965L2

I don't click any of the side menu.

Hope this helps

@avitorio
Copy link
Owner

@philals Oh wow, thanks for flagging this! I'll look into it asap!

@avitorio
Copy link
Owner

Thank you @lexstefan and @philals - this has been fixed and will be available in the next minor release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants