Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes should be reworked #14

Open
avl opened this issue Jul 18, 2020 · 2 comments
Open

Attributes should be reworked #14

avl opened this issue Jul 18, 2020 · 2 comments

Comments

@avl
Copy link
Owner

avl commented Jul 18, 2020

Savefile uses a whole lot of attributes right now, all with the prefix 'savefile_' in their names.

It would probably be better if instead the attribute was called 'savefile', and then different arguments to this single attribute were used.

This would be a breaking change without a huge tangible benefit. There are a few ways forward

  • Just do the change, increasing the semver major version.
  • Add the new attribute in parallel with the old ones, and deprecate the old ones in the next major version.
@semirix
Copy link

semirix commented Apr 7, 2022

Are you talking about a similar approach to serde, as outlined here? That would certainly make it look much cleaner.

@avl
Copy link
Owner Author

avl commented Apr 7, 2022

Yes, something like:

#[savefile(versions="1..")]

instead of today's:

#[savefile_versions="1.."]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants