Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SubjectType edit triggers Subjects lastModifiedDateTime modification #689

Open
Tracked by #1538
1t5j0y opened this issue Feb 9, 2024 · 0 comments
Open
Tracked by #1538

Comments

@1t5j0y
Copy link
Contributor

1t5j0y commented Feb 9, 2024

Context

If registration sync concepts are configured for a subject type, there is a batch job to update last modified date time for subjects of this subject type so that it will get synced to users.

Problem

Any subject type edit, even when not configuring registration sync concepts is triggering the batch job.

Issues:

PUT /web/subjectType/ needs some cleanup.

Investigation done as part of #686

  1. isSyncRegistrationConcept1Usable and isSyncRegistrationConcept2Usable are supposed to be system managed properties but are present in the external contract and writeable via them. When these are set to 'false', any update to the subject type triggers the sync attribute job and modifies last_modified_date_time for all subjects of that subject type.
  2. The value of the 'usable' fields needs to be managed better i.e. currently false and null have the same meaning to us but cause different behaviour (point 1).
    -- Solutions: Either make the fields boolean or manage the value correctly i.e. usable should always be null when there is no corresponding sync registration concept.
  3. Logic is split across controller and service layer making it hard to write tests for.
@1t5j0y 1t5j0y changed the title Update Subject Type refactor SubjectType edit triggers Subjects lastModifiedDateTime modification Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New Issues
Development

No branches or pull requests

1 participant