#707 | Leading spaces when creating users are now trimmed! #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ombhardwajj The changes to BulkUploadS3Service still seems to be present in this PR. Can you please remove it as well? |
…h were modifed have been reverted back Squashed the last two commits Usercontract java files are now responsible for trimming Username trimming is now done in usercontract class Usercontract class has been updated BulkUploadS3Service and other files reverted back to original code
|
@vinayvenu , I've reverted back the BulkUploadS3Service as well, sorry for the oversight before! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #707 the issues of bad data in system caused by Leading spaces when creating users .