Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In RWB in csv upload there is location type dam/nalla is not accepting the value #1166

Open
AchalaBelokar opened this issue Mar 15, 2024 · 2 comments

Comments

@AchalaBelokar
Copy link

AchalaBelokar commented Mar 15, 2024

Describe the bug
In RWB in csv upload there is location type dam/nalla is not accepting the value
https://app.rwb.avniproject.org
Login with AchalaB@rwb24uat
prod Staging.csv
tried with csv it is giving invalid address but it is valid user

To Reproduce
Steps to reproduce the behavior:

  1. Login with AchalaB@rwb24uat
  2. click on admin
  3. click on upload
  4. upload csv on farmer registration
  5. see the error

Analysis:

Identify if some fix made in Avni need to be released to rwb env or new fix needed, since RWB env frequently deals with CSV uploads.

@AchalaBelokar AchalaBelokar added the bug Something isn't working label Mar 15, 2024
@mahalakshme
Copy link
Contributor

mahalakshme commented Mar 15, 2024

@AchalaBelokar did the above issue happen in prerelease also?

@mahalakshme mahalakshme removed the bug Something isn't working label Mar 15, 2024
@1t5j0y 1t5j0y self-assigned this Mar 20, 2024
@1t5j0y
Copy link
Contributor

1t5j0y commented Mar 20, 2024

Issue is because subject csv upload does not currently handle having multiple location types at the lowest level.

SubjectWriter.write sorts the locationTypes by level and calls AddressLevelCreator.findAddressLevel which uses only the last element for further processing.

For setups where multiple location types are at the same lowest level, different location types could be referred to in different runs.

Not fixing immediately as prod orgs don't have setups like this typically or do not use the different locationTypes at the lowest level even if setup. Moving to hold.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Hold
Development

No branches or pull requests

3 participants