Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write rule failures in DEA to rule failure telemetry #34

Open
Tracked by #1614
1t5j0y opened this issue Feb 10, 2023 · 2 comments
Open
Tracked by #1614

Write rule failures in DEA to rule failure telemetry #34

1t5j0y opened this issue Feb 10, 2023 · 2 comments

Comments

@1t5j0y
Copy link
Contributor

1t5j0y commented Feb 10, 2023

Currently rule failures in DEA break the application flow and do not write to rule failure telemetry.

Action Item for this story:
Consolidate RuleFailureLog and RuleFailureTelementry tables.

Acceptance criteria

Rule failures should not break DEA app flow
Rule failures should be logged to rule failure telemetry

@1t5j0y 1t5j0y self-assigned this Feb 10, 2023
@1t5j0y
Copy link
Contributor Author

1t5j0y commented Feb 15, 2023

Realised there is a separate implementation of DEA error handling in avni-server that writes to rule_failure_log table. This does not currently work in all cases.
Also came across avniproject/avni-client#1172 to consolidate all errors to the same table. Putting on hold till we discuss and finalize the approach to be taken.
FYI @vinayvenu

@1t5j0y 1t5j0y removed their assignment Feb 15, 2023
@himeshr
Copy link
Contributor

himeshr commented Feb 16, 2023

Action Item for this story: Consolidate RuleFailureLog and RuleFailureTelementry tables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Analysis
Development

No branches or pull requests

3 participants