Skip to content
This repository has been archived by the owner on Jan 31, 2024. It is now read-only.

Downloaded video has a 2-seconds of empty space before the start of the video. #89

Closed
RalkeyOfficial opened this issue May 21, 2023 · 4 comments
Labels
bug Something isn't working solved

Comments

@RalkeyOfficial
Copy link

RalkeyOfficial commented May 21, 2023

This problem is kinda difficult to explain and very random, but I will do my best.

I just ran the download and most of the videos have this time before the start of the video where nothing happens.

Sometimes the video starts instant, and sometimes the video has 2 seconds of nothing at the start.
The audio will also start playing in these 2 seconds of emptiness.

It's not necessarily a massive issue as the video does play after those 2 seconds, but it's definitely not intended.

@Avnsx
Copy link
Owner

Avnsx commented May 21, 2023

I had someone test that m3u8 function I wrote before and they also have had that same issue.

Unfortunately for me it never happens though, so I'm not sure how I can fix a bug that won't replicate on my local system and currently also have no clue why that happens

@Avnsx Avnsx added bug Something isn't working contributors appreciated help adding this functionality/feature help wanted Extra attention is needed investigating currently looking into this issue labels May 21, 2023
@Avnsx
Copy link
Owner

Avnsx commented May 21, 2023

Nvm it also happens for me, it's just I was using VLC media player and VLC automatically cuts away those 2 seconds of nothingness, so I wasn't able to notice it, until I tried playing back the media in another video player.

Edit: Solved the issue locally, will publish fix tmrw.

@Avnsx Avnsx added solved and removed contributors appreciated help adding this functionality/feature help wanted Extra attention is needed investigating currently looking into this issue labels May 22, 2023
Avnsx added a commit that referenced this issue May 23, 2023
changes:
-  filenames are now partially utilising ISO 8601; so they're sortable by name again
- update_recent_download will now entirely get removed from config.ini
	- functionality will remain just referred to as "deduplication"
- improved error robustness

fixed a bug :
- where content would falsely get flagged as preview (#91)
- where a TypeError would be caused (#90)
- where m3u8 videos would transcode with a 2 second delay at the start (#89)
@Avnsx
Copy link
Owner

Avnsx commented May 23, 2023

Should be fixed with commit 2736a54

@Avnsx
Copy link
Owner

Avnsx commented Jun 12, 2023

Closing, as the 0.4 version is finally released and does target & solve the topics mentioned within this issue.

If you're on the previous 0.3.5 version you can comfortably update using the updater.exe supplied in the version, or just manually download the 0.4 version from the repositories Releases.

@Avnsx Avnsx closed this as completed Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working solved
Projects
None yet
Development

No branches or pull requests

2 participants