avocado/utils/ssh.py: add timeout functionality #5775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear contributor,
As for the Avocado utility modules (“avocado.utils”) it is OK to introduce new functionality, |
clebergnu
force-pushed
the
zuohanxu_ssh_timeout
branch
from
e56d9c1
to
baf0053
Compare
This uses the remote side "timeout" command to implement a timeout for the actual command the user intends to run. The arguments given are the simplest possible to be made compatible with "timeout" implementations such as the ones given by busybox. While it's not possible to have a functional test at this point (because the test would need a second and properly configured machine), the example API script should serve as a proof that this implementation behaves correctly: $ python3 examples/apis/utils/ssh_timeout.py 10.571667929994874 1.4050129299866967 Signed-off-by: zuohanxu <zuohanxu@uniontech.com> Signed-off-by: Cleber Rosa <crosa@redhat.com>
clebergnu
force-pushed
the
zuohanxu_ssh_timeout
branch
from
baf0053
to
3afa268
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the remote side "timeout" command to implement a timeout for the actual command the user intends to run. The arguments given are the simplest possible to be made compatible with "timeout" implementations such as the ones given by busybox.
While it's not possible to have a functional test at this point (because the test would need a second and properly configured machine), the example API script should serve as a proof that this implementation behaves correctly:
$ python3 examples/apis/utils/ssh_timeout.py
10.571667929994874
1.4050129299866967
This is a follow up to #5654