Avocado Instrumented Test: introduce a multiplier for the timeout #5820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear contributor,
As for the Avocado utility modules (“avocado.utils”) it is OK to introduce new functionality, |
clebergnu
force-pushed
the
timeout_factor
branch
from
21b503d
to
17785e1
Compare
|
/packit copr-build |
The section on test timeout spends too much energy on the varianter. Let's use simple test parameters which are more than adequate for this example. Signed-off-by: Cleber Rosa <crosa@redhat.com>
clebergnu
force-pushed
the
timeout_factor
branch
from
17785e1
to
e7cd35e
Compare
This introduces a "timeout factor", basically another parameter that Avocado Instrumented tests will respect that will be used to alter the actual timeout. The reason for this feature is the fact that tests are coded with timeouts, but, their actual needed timeouts will depend on the environment they are running on. It's not OK to expect the test code to be modified when the environment changes significantly for an execution of the tests (say on faster or slower CPUs or networks). The implementation is done in a way that adds no new attributes or methods to the avocado.Test class. Signed-off-by: Cleber Rosa <crosa@redhat.com>
clebergnu
force-pushed
the
timeout_factor
branch
from
e7cd35e
to
f8e9cc4
Compare
richtja
approved these changes
Dec 7, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a "timeout factor", basically another parameter that Avocado Instrumented tests will respect that will be used to alter the actual timeout.
The reason for this feature is the fact that tests are coded with timeouts, but, their actual needed timeouts will depend on the environment they are running on. It's not OK to expect the test code to be modified when the environment changes significantly for an execution of the tests (say on faster or slower CPUs or networks).