Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avocode uninstall does not remove all files if the App is running simultaneously #353

Closed
VaclovasV opened this issue Jul 17, 2015 · 11 comments
Closed
Assignees
Labels

Comments

@VaclovasV
Copy link

@VaclovasV VaclovasV commented Jul 17, 2015

Every time after uninstall i try to install app again, i get this error: http://prntscr.com/7tno71

@VaclovasV
Copy link
Author

@VaclovasV VaclovasV commented Jul 17, 2015

after removing items related with Avocode from C:\Users******\AppData it started to work

@rychlis
Copy link
Member

@rychlis rychlis commented Jul 28, 2015

when I try to uninstall Avocode there will only remain Update.exe in "%LocalAppData%\avocode" which is correct behavior. Did the uninstaller leave any more files there for you?

One way I can reproduce the error is if I leave the Avocode App open while I uninstall it and install it again. In this case installer will give me the same error because it is not able to change avocode binary and files as it's still running. Was this your case maybe?

@rychlis rychlis added the windows label Jul 28, 2015
@VaclovasV
Copy link
Author

@VaclovasV VaclovasV commented Aug 10, 2015

can be :) maybe uninstall process shouldn't work while app is running?

@rychlis
Copy link
Member

@rychlis rychlis commented Oct 23, 2015

Yes but it seems to be very minor issue, why would you try to uninstall the app while it's running? What's the usecase?

@VaclovasV
Copy link
Author

@VaclovasV VaclovasV commented Oct 23, 2015

2 of 9 people in our company had this issue, uninstallation wizard allowed to uninstall app, then it was not closed. I don't think, that issue is minor.

@rychlis
Copy link
Member

@rychlis rychlis commented Oct 23, 2015

Ok there are two related problems:

  1. When you uninstall the app while it's running, the files are not completely deleted. This should be fixed and it would be easy to implement after this issue is fixed in the library we use: Squirrel/Squirrel.Windows#197
  2. If you try to install the app after 1. it will fail. When I asked for the usecase I was talking only about this second problem in my comment, why would you uninstall the app while running and install it again?

But generally it's not that minor, sorry about that

@VaclovasV
Copy link
Author

@VaclovasV VaclovasV commented Oct 23, 2015

Avocode had syncing problems, so i tried to install and reinstall it (what is the difference?), after this - I couldn't event install it, because files existed. Then i removed them - install completed.

@rychlis rychlis changed the title Can't install avocode after uninstall Avocode uninstall does not remove all files if the App is running simultaneously Oct 23, 2015
@rychlis
Copy link
Member

@rychlis rychlis commented Oct 23, 2015

OK thanks for the info. We'll investigate this further and try to kill all running Avocode instances when uninstalling which should fix the issue.

@VaclovasV
Copy link
Author

@VaclovasV VaclovasV commented Oct 23, 2015

I think, you should go with solution like adobe does with their products: can't uninstall anything, while software is up. You can only press retry or cancel.

@VaclovasV
Copy link
Author

@VaclovasV VaclovasV commented Oct 23, 2015

@rychlis now I see what you mean, but scenario was not like i wanted to install second avocode, then running first one. Steps to reproduce:

  1. Run avocode
  2. When running - try to uninstall, uninstall process completes successfully
  3. Close application, try to install avocode again.
  4. App fails, because of existing files
@rychlis
Copy link
Member

@rychlis rychlis commented Jan 26, 2016

We've updated the installer to newer version of Squirrel.Windows in Avocode 2.5.2, the uninstaller will now automatically close any running Avocode instances before uninstalling.

@rychlis rychlis closed this Jan 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.