Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpscout enhancements #305

Merged
merged 4 commits into from Jun 13, 2022
Merged

Helpscout enhancements #305

merged 4 commits into from Jun 13, 2022

Conversation

narthur
Copy link
Collaborator

@narthur narthur commented Jun 13, 2022

No description provided.

@narthur narthur requested a review from mattleff as a code owner June 13, 2022 19:17
@vercel
Copy link

vercel bot commented Jun 13, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
audioverse-next ✅ Ready (Inspect) Visit Preview Jun 13, 2022 at 7:22PM (UTC)

@github-actions
Copy link

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 140.94 KB (🟡 +32 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Fifty Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (225 KB)
/[language]/about/[id]/[[...slugs]] 18.13 KB 159.07 KB 70.70% (🟡 +0.03%)
/[language]/bibles 36.19 KB 177.13 KB 78.73% (🟡 +0.02%)
/[language]/bibles/[id]/[[...slugs]] 23.04 KB 163.98 KB 72.88% (🟡 +0.03%)
/[language]/bibles/[id]/[book]/[chapter] 29.24 KB 170.19 KB 75.64% (🟡 +0.02%)
/[language]/blog/[id]/[[...slugs]] 23.15 KB 164.09 KB 72.93% (🟡 +0.03%)
/[language]/blog/page/[i] 23.11 KB 164.06 KB 72.91% (🟡 +0.03%)
/[language]/books/[id]/[[...slugs]] 24.94 KB 165.89 KB 73.73% (🟡 +0.03%)
/[language]/books/page/[i] 23.19 KB 164.13 KB 72.95% (🟡 +0.03%)
/[language]/books/tracks/[id]/[[...slugs]] 37.64 KB 178.58 KB 79.37% (🟡 +0.03%)
/[language]/conferences/[id]/[[...slug]] 31.01 KB 171.96 KB 76.43% (🟡 +0.02%)
/[language]/conferences/[id]/presenters/page/[i] 23.09 KB 164.04 KB 72.91% (🟡 +0.03%)
/[language]/conferences/[id]/sequences/page/[i] 24.67 KB 165.62 KB 73.61% (🟡 +0.03%)
/[language]/conferences/[id]/teachings/page/[i] 21.42 KB 162.37 KB 72.16% (🟡 +0.03%)
/[language]/conferences/page/[i] 29.2 KB 170.15 KB 75.62% (🟡 +0.03%)
/[language]/embed/media/[id] 26.78 KB 167.72 KB 74.54% (🟡 +0.03%)
/[language]/library/playlist/[id] 22.53 KB 163.48 KB 72.66% (🟡 +0.02%)
/[language]/presenters/[id]/[[...slug]] 31.58 KB 172.53 KB 76.68% (🟡 +0.03%)
/[language]/presenters/[id]/appears/page/[i] 30.77 KB 171.71 KB 76.32% (🟡 +0.03%)
/[language]/presenters/[id]/sequences/page/[i] 24.64 KB 165.58 KB 73.59% (🟡 +0.03%)
/[language]/presenters/[id]/teachings/page/[i] 21.68 KB 162.62 KB 72.28% (🟡 +0.03%)
/[language]/presenters/[id]/top 20.11 KB 161.06 KB 71.58% (🟡 +0.04%)
/[language]/presenters/letter/[letter] 18.93 KB 159.87 KB 71.05% (🟡 +0.03%)
/[language]/releases/[id] 18.97 KB 159.91 KB 71.07% (🟡 +0.03%)
/[language]/search 33.69 KB 174.63 KB 77.62% (🟡 +0.11%)
/[language]/search/collections/page/[i] 29.24 KB 170.19 KB 75.64% (🟡 +0.03%)
/[language]/search/persons/page/[i] 21.67 KB 162.61 KB 72.27% (🟡 +0.03%)
/[language]/search/sequences/page/[i] 23.24 KB 164.19 KB 72.97% (🟡 +0.03%)
/[language]/search/sponsors/page/[i] 20.88 KB 161.83 KB 71.92% (🟡 +0.04%)
/[language]/search/teachings/page/[i] 19.77 KB 160.71 KB 71.43% (🟡 +0.03%)
/[language]/series/[id]/[[...slug]] 24.95 KB 165.89 KB 73.73% (🟡 +0.03%)
/[language]/series/page/[i] 23.2 KB 164.14 KB 72.95% (🟡 +0.03%)
/[language]/songs/[id]/[[...slugs]] 37.63 KB 178.58 KB 79.37% (🟡 +0.03%)
/[language]/songs/albums/[id]/[[...slugs]] 24.95 KB 165.9 KB 73.73% (🟡 +0.03%)
/[language]/songs/book/[book] 22.71 KB 163.65 KB 72.74% (🟡 +0.02%)
/[language]/songs/book/[book]/[id]/[[...slugs]] 37.79 KB 178.74 KB 79.44% (🟡 +0.03%)
/[language]/sponsors/[id]/[[...slugs]] 30.61 KB 171.56 KB 76.25% (🟡 +0.02%)
/[language]/sponsors/[id]/conferences/page/[i] 29.99 KB 170.94 KB 75.97% (🟡 +0.03%)
/[language]/sponsors/[id]/series/page/[i] 23.91 KB 164.85 KB 73.27% (🟡 +0.03%)
/[language]/sponsors/[id]/teachings/page/[i] 20.91 KB 161.85 KB 71.93% (🟡 +0.03%)
/[language]/sponsors/letter/[letter] 18.75 KB 159.7 KB 70.98% (🟡 +0.02%)
/[language]/stories/[id]/[[...slugs]] 37.64 KB 178.58 KB 79.37% (🟡 +0.03%)
/[language]/stories/albums/[id]/[[...slugs]] 24.95 KB 165.9 KB 73.73% (🟡 +0.03%)
/[language]/stories/albums/page/[i] 23.21 KB 164.15 KB 72.96% (🟡 +0.03%)
/[language]/teachings/[id]/[[...slug]] 37.64 KB 178.58 KB 79.37% (🟡 +0.03%)
/[language]/teachings/all/page/[i] 20.79 KB 161.74 KB 71.88% (🟡 +0.03%)
/[language]/teachings/audio/page/[i] 20.79 KB 161.74 KB 71.88% (🟡 +0.03%)
/[language]/teachings/trending/all 19.44 KB 160.39 KB 71.28% (🟡 +0.03%)
/[language]/teachings/trending/audio 19.05 KB 159.99 KB 71.11% (🟡 +0.02%)
/[language]/teachings/trending/video 19.05 KB 159.99 KB 71.11% (🟡 +0.02%)
/[language]/teachings/video/page/[i] 20.79 KB 161.74 KB 71.88% (🟡 +0.03%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 5% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Contributor

@mattleff mattleff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@narthur narthur merged commit e981348 into master Jun 13, 2022
@narthur narthur deleted the helpscout-enhancements branch June 13, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants