RFC: Add API to suspend/restore interrupts ... #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old llvm_asm! has been removed. Therefore, it doesn't compile on new rustc anymore.
stappersg
reviewed
Jun 8, 2022
| @@ -2,35 +2,77 @@ | |||
|
|
|||
| use core::prelude::v1::*; | |||
| use core::marker::PhantomData; | |||
| use core::arch::asm; | |||
There was a problem hiding this comment.
That addition is meanwhile in place.
stappersg
reviewed
Jun 8, 2022
| @@ -2,35 +2,77 @@ | |||
|
|
|||
| use core::prelude::v1::*; | |||
| use core::marker::PhantomData; | |||
| use core::arch::asm; | |||
There was a problem hiding this comment.
That addition is meanwhile in place.
|
This merge request now needs git rebase. (Sorry for not (yet??) contributing to the requested discussion.) |
1 similar comment
|
This merge request now needs git rebase. (Sorry for not (yet??) contributing to the requested discussion.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... similar to the current without_interrupts() helper.
What do you think about this?
I renamed the existing disable/enable API to with_irqs_disabled().
The new API for suspend/restore is with_irqs_suspended().
The old without_interrupts remains as deprecated alias.
I'm not so sure about the naming. Suggestions for better naming are welcome. :)
This is completely untested. Just for discussion.