Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AFR-640 Add datetime.datetime and datetime.timedelta to aliasing context, #1277

Open
taine-bot opened this issue Sep 29, 2020 · 3 comments
Open
Labels
featurereq P4: Low Issues that may be implemented eventually. +10 FRs with at least 10 upvotes.

Comments

@taine-bot
Copy link
Collaborator

taine-bot commented Sep 29, 2020

Feature Request: Add datetime.datetime and datetime.timedelta to aliasing context,
Who would use it? Anyone who is making aliasing involving time (downtime, cooldowns, etc)
What part of the bot? Aliasing
How would it work? Exposing the datetime and timedelta classes could use their functionality like datetime.now() + datetime.timedelta(days=1) to fetch one day from now
Why should this be added? It would make working with time much easier and would allow us to avoid using complex calculations to get the date based off the current time()

  • Dr Turtle#1771

Upvote - Velglarn#4688

Upvote - Riptidecord#7191

Upvote - Crys#4802

Upvote - Derixyleth#0636

Upvote - Dusk Argentum#6530

Upvote - Mobius#1442

Upvote - Zekl#7118

Upvote - Brinjal#4037

Upvote - 623277032930803742

Upvote - topper#0294

Upvote - gil#0527

Upvote - Slosh#7048

Upvote - rewrite#4401

Upvote - Ithala#3408

Upvote - Dice#6153

Upvote - VeryGreatFrog#6253

Upvote - TheReverendB#1377

Upvote - bobschnitzenheimer#2159

Votes: +18 / -0

@zhudotexe zhudotexe added this to To Consider in Feature Requests Sep 30, 2020
@zhudotexe zhudotexe added the P4: Low Issues that may be implemented eventually. label Oct 14, 2020
@zhudotexe zhudotexe moved this from To Consider to To do in Feature Requests Oct 14, 2020
@1drturtle
Copy link
Contributor

1drturtle commented Nov 19, 2020

(Commenting on this before it gets stale'd)
I'd still like to see this added, but I do realize that it is a big security concern.

timedelta - This class contains limits on how many days/seconds can be used, see https://docs.python.org/3/library/datetime.html#datetime.timedelta.min and https://docs.python.org/3/library/datetime.html#datetime.timedelta.max

datetime.datetime - Also has similar limits (https://docs.python.org/3/library/datetime.html#datetime.datetime.min, https://docs.python.org/3/library/datetime.html#datetime.datetime.max)

Not mentioned in the original FR but also datetime.now() / datetime.utcnow() for storing dates easier.

@taine-bot taine-bot added the +10 FRs with at least 10 upvotes. label Dec 23, 2020
@ghost
Copy link

ghost commented May 17, 2021

thanks @zhudotexe for replying on my draconic issue

@1drturtle i think you accidentally pasted the same link multiple times in your comment above

@1drturtle
Copy link
Contributor

@1drturtle i think you accidentally pasted the same link multiple times in your comment above
oh whoops, fixed that.

for more in-depth discussions, hop on the avrae dev discord at https://support.avrae.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
featurereq P4: Low Issues that may be implemented eventually. +10 FRs with at least 10 upvotes.
Projects
Development

No branches or pull requests

3 participants