Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework aggressive syncing #72

Open
avram opened this issue Dec 1, 2011 · 2 comments
Open

Rework aggressive syncing #72

avram opened this issue Dec 1, 2011 · 2 comments
Assignees

Comments

@avram
Copy link
Owner

avram commented Dec 1, 2011

Aggressive syncing is currently based on a misunderstanding that led me to believe that a collection with modified items will show up as modified. We should instead request the most recently modified items (/items), requesting more pages until we get to items unmodified since our last sync. This means maintaining a last-sync timestamp. I believe this will address the reported issue with notes created on the server not showing up in Zandy; I think they aren't showing up unless the item's attachment view is the origin of the sync request.

@judeibe
Copy link
Contributor

judeibe commented Dec 12, 2011

I haven't fully researched your code but you should keep track of etags and only refresh when the etag changes. Zoteros api supports this.

@avram
Copy link
Owner Author

avram commented Dec 12, 2011

Zandy currently does record the etag-- otherwise it would be impossible to write changes back to the server. The problem is determining what changes server-side have occurred since the last sync; we can do that by requesting all items and comparing etags, but that's a pretty major undertaking, especially for large collections (and there are collections of 10K+ out there). We can certainly use the datemodified sort to just get the changed items as described above-- so that's what I had in mind.

Changes in collection membership and server-side deletes (issue #70) are also hard to detect with the current API.

@ghost ghost assigned avram Dec 24, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants