Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display likes #27

Merged
merged 3 commits into from Mar 9, 2022
Merged

Display likes #27

merged 3 commits into from Mar 9, 2022

Conversation

awais-amjed
Copy link
Owner

In this PR, the following changes were introduced:

  • Implemented functions for posting a like and getting all likes.
  • Displayed the number of likes in the Jokes Card for every item.
  • Fixed Header on Mobile Screens.

image

Copy link
Collaborator

@Bavon101 Bavon101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello @awais-amjed ,
Your changes are remarkably greater,

  • Your commits are great

  • The UI is nice

  • The code is clean
    I just found some minor issue or just a bad misplaced like button, how does one like a joke?
    I've tried looking but only the likes counts are displayed, without an original action.

  • Please do add a like Icon or button for a user to be able to initiate their likes count.
    giggy_like

@awais-amjed
Copy link
Owner Author

@Bavon101 Thanks for the review, The Like button is not a part of this PR, it's the part of the next PR. You can check that in the Kanban Board.

@Bavon101
Copy link
Collaborator

Bavon101 commented Mar 9, 2022

@Bavon101 Thanks for the review, The Like button is not a part of this PR, it's the part of the next PR. You can check that in the Kanban Board.

Noted @awais-amjed , Sorry for the misunderstanding.

@awais-amjed
Copy link
Owner Author

awais-amjed commented Mar 9, 2022

No Problem @Bavon101 . Can you please approve the PR, Thanks.

Copy link
Collaborator

@Bavon101 Bavon101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @awais-amjed ,
Your project meets all the changes in scope.✔
Great work, I give a green light for a merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants